Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19711#discussion_r150712289
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
    @@ -113,7 +116,7 @@ class SQLListener(conf: SparkConf) extends 
SparkListener with Logging {
        */
       private val _jobIdToExecutionId = mutable.HashMap[Long, Long]()
     
    -  private val _stageIdToStageMetrics = mutable.HashMap[Long, 
SQLStageMetrics]()
    +  private val _stageIdToStageMetrics = mutable.LinkedHashMap[Long, 
SQLStageMetrics]()
    --- End diff --
    
    Java's `LinkedHashMap` can be overridden with an custom implementation of 
`removeEldestEntry`, that will save the codes done below. It is not the user 
who call this `removeEldestEntry`...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to