Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r150751761
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -92,6 +92,11 @@ object SparkSubmit extends CommandLineUtils with Logging
{
private val CLASS_NOT_FOUND_EXIT_STATUS = 101
+ // Following constants are visible for testing.
+ private[deploy] val YARN_SUBMIT_CLASS =
"org.apache.spark.deploy.yarn.YarnClusterApplication"
+ private[deploy] val REST_SUBMIT_CLASS =
classOf[RestSubmissionClientApp].getName()
+ private[deploy] val STANDALONE_SUBMIT_CLASS =
classOf[ClientApp].getName()
--- End diff --
Maybe we can rename these variables to `XXX_CLUSTER_SUBMIT_CLASS`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
