Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19272#discussion_r151216025
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -140,13 +140,24 @@ class SparkHadoopUtil extends Logging {
         if (!new File(keytabFilename).exists()) {
           throw new SparkException(s"Keytab file: ${keytabFilename} does not 
exist")
         } else {
    -      logInfo("Attempting to login to Kerberos" +
    -        s" using principal: ${principalName} and keytab: 
${keytabFilename}")
    +      logInfo("Attempting to login to Kerberos " +
    +        s"using principal: ${principalName} and keytab: ${keytabFilename}")
           UserGroupInformation.loginUserFromKeytab(principalName, 
keytabFilename)
         }
       }
     
       /**
    +   * Add or overwrite current user's credentials with serialized 
delegation tokens,
    +   * also confirms correct hadoop configuration is set.
    +   */
    +  def addDelegationTokens(tokens: Array[Byte], sparkConf: SparkConf) {
    --- End diff --
    
    Always forget this class is public. Add `private[spark]`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to