Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19741#discussion_r151231022
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -268,8 +268,13 @@ private[spark] abstract class YarnSchedulerBackend(
             logWarning(reason.toString)
             driverEndpoint.ask[Boolean](r).onFailure {
    --- End diff --
    
    I wonder if using `ask` here is doing anything useful at all. Instead, 
using `send` would be cheaper, and the handler for `RemoveExecutor` can log 
whatever errors it runs into instead.
    
    Then this could just be:
    
    ```
    if (!stopped.get()) {
      driverEndpoint.send(...)
    }
    ```
    
    (And the driver endpoint will probably need a minor change too.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to