Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17436#discussion_r151472401
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -80,6 +80,22 @@ package object config {
         .bytesConf(ByteUnit.MiB)
         .createWithDefaultString("1g")
     
    +  private[spark] val MEMORY_OFFHEAP_ENABLED = 
ConfigBuilder("spark.memory.offHeap.enabled")
    +    .doc("If true, Spark will attempt to use off-heap memory for certain 
operations. " +
    +      "If off-heap memory use is enabled, then spark.memory.offHeap.size 
must be positive.")
    +    .withAlternative("spark.unsafe.offHeap")
    --- End diff --
    
    do we still need this as we already did it in 
https://github.com/apache/spark/pull/17436/files#diff-529fc5c06b9731c1fbda6f3db60b16aaR658
 ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to