Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r151890602
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala
---
@@ -158,8 +196,8 @@ class FilterEstimationSuite extends
StatsEstimationTestBase {
val condition = Not(And(LessThan(attrInt, Literal(3)), Literal(null,
IntegerType)))
validateEstimatedStats(
Filter(condition, childStatsTestPlan(Seq(attrInt), 10L)),
- Seq(attrInt -> colStatInt.copy(distinctCount = 8)),
- expectedRowCount = 8)
+ Seq(attrInt -> colStatInt.copy(distinctCount = 7)),
--- End diff --
Shall we add new test cases for filter estimation based on histogram,
instead of modifying existing test results?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
