Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19781#discussion_r151953815
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SortExec.scala ---
    @@ -124,9 +124,11 @@ case class SortExec(
       // Name of sorter variable used in codegen.
       private var sorterVariable: String = _
     
    -  // The result rows come from the sort buffer, so this operator doesn't 
need to copy its result
    -  // even if its child does.
    -  override def needCopyResult: Boolean = false
    +  private var _needCopyResult: Option[Boolean] = None
    --- End diff --
    
    my bad, I rechecked again and I found we didn't need the change in 
`SortExec` and `HashAggregateExec`. I'll update soon.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to