Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19787#discussion_r152013410
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -2205,6 +2205,10 @@ def udf(f=None, returnType=StringType()):
             rows that do not satisfy the conditions, the suggested workaround 
is to incorporate the
             condition logic into the functions.
     
    +    .. note:: Users can't rely on short-curcuit evaluation of boolean 
expressions to execute
    --- End diff --
    
    Looks okay but how about combining this comment with the one above and 
making it shorter if possible? Like .. udfs don't support conditional 
expression or short curcuiting and it ends up with being executed all 
internally. If it depends on ..., workaround blabla and blabla.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to