Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2712#discussion_r18743890 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1409,7 +1410,9 @@ object SparkContext extends Logging { simpleWritableConverter[Boolean, BooleanWritable](_.get) implicit def bytesWritableConverter(): WritableConverter[Array[Byte]] = { - simpleWritableConverter[Array[Byte], BytesWritable](_.getBytes) + simpleWritableConverter[Array[Byte], BytesWritable](bw => + Arrays.copyOfRange(bw.getBytes, 0, bw.getLength) --- End diff -- Could you add a one-line comment here that explains why we need to make this copy?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org