Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19786#discussion_r152322074
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -132,15 +132,20 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
AppStatusStore.CURRENT_VERSION, logDir.toString())
try {
- open(new File(path, "listing.ldb"), metadata)
+ open(dbPath, metadata)
} catch {
// If there's an error, remove the listing database and any existing
UI database
// from the store directory, since it's extremely likely that
they'll all contain
// incompatible information.
case _: UnsupportedStoreVersionException | _:
MetadataMismatchException =>
logInfo("Detected incompatible DB versions, deleting...")
path.listFiles().foreach(Utils.deleteRecursively)
- open(new File(path, "listing.ldb"), metadata)
+ open(dbPath, metadata)
+ case e: Exception =>
+ // Get rid of the old data and re-create it. The store is either
old or corrupted.
--- End diff --
`is either old`, I think the old version problems is handled by the
previous `case`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
