Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2761#issuecomment-58769389
> I quite like standardizing style, but doesn't this have the same problem
mentioned before, that it's going to break a lot of potential merge commits?
When I [did this for Python](https://github.com/apache/spark/pull/1744), I
fixed all outstanding style problems as part of the same PR that introduced
that check. It forced some people to rebase their open PRs, but it was a
once-and-done thing.
Are we opposed to doing that here? Trying to ease this check in by
enforcing it only on new code is a good idea, but why not just get the style
cleanup over with in this PR? It looks like @sarutak has done just that. Some
people will have to rebase once and this style problem is done with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
