Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152425778
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources
+
+import org.apache.spark.sql.catalyst.dsl.expressions._
+import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.sql.catalyst.plans.PlanTest
+import org.apache.spark.sql.sources
+import org.apache.spark.sql.test.SharedSQLContext
+
+class DataSourceStrategySuite extends PlanTest with SharedSQLContext {
+
+ test("translate simple expression") {
+ val attrInt = 'cint.int
+ val attrStr = 'cstr.string
+
+ testTranslateFilter(EqualTo(attrInt, 1), Some(sources.EqualTo("cint",
1)))
+ testTranslateFilter(EqualTo(1, attrInt), Some(sources.EqualTo("cint",
1)))
+
+ testTranslateFilter(EqualNullSafe(attrStr, Literal(null)),
+ Some(sources.EqualNullSafe("cstr", null)))
+ testTranslateFilter(EqualNullSafe(Literal(null), attrStr),
+ Some(sources.EqualNullSafe("cstr", null)))
+
+ testTranslateFilter(GreaterThan(attrInt, 1),
Some(sources.GreaterThan("cint", 1)))
+ testTranslateFilter(GreaterThan(1, attrInt),
Some(sources.LessThan("cint", 1)))
+
+ testTranslateFilter(LessThan(attrInt, 1),
Some(sources.LessThan("cint", 1)))
+ testTranslateFilter(LessThan(1, attrInt),
Some(sources.GreaterThan("cint", 1)))
+
+ testTranslateFilter(GreaterThanOrEqual(attrInt, 1),
Some(sources.GreaterThanOrEqual("cint", 1)))
+ testTranslateFilter(GreaterThanOrEqual(1, attrInt),
Some(sources.LessThanOrEqual("cint", 1)))
+
+ testTranslateFilter(LessThanOrEqual(attrInt, 1),
Some(sources.LessThanOrEqual("cint", 1)))
+ testTranslateFilter(LessThanOrEqual(1, attrInt),
Some(sources.GreaterThanOrEqual("cint", 1)))
+
+ testTranslateFilter(InSet(attrInt, Set(1, 2, 3)),
Some(sources.In("cint", Array(1, 2, 3))))
+
+ testTranslateFilter(In(attrInt, Seq(1, 2, 3)), Some(sources.In("cint",
Array(1, 2, 3))))
+
+ testTranslateFilter(IsNull(attrInt), Some(sources.IsNull("cint")))
+ testTranslateFilter(IsNotNull(attrInt),
Some(sources.IsNotNull("cint")))
+
+ // cint > 1 AND cint < 10
+ testTranslateFilter(And(
+ GreaterThan(attrInt, 1),
+ LessThan(attrInt, 10)),
+ Some(sources.And(
+ sources.GreaterThan("cint", 1),
+ sources.LessThan("cint", 10))))
+
+ // cint >= 8 OR cint <= 2
+ testTranslateFilter(Or(
+ GreaterThanOrEqual(attrInt, 8),
+ LessThanOrEqual(attrInt, 2)),
+ Some(sources.Or(
+ sources.GreaterThanOrEqual("cint", 8),
+ sources.LessThanOrEqual("cint", 2))))
+
+ testTranslateFilter(Not(GreaterThanOrEqual(attrInt, 8)),
+ Some(sources.Not(sources.GreaterThanOrEqual("cint", 8))))
+
+ testTranslateFilter(StartsWith(attrStr, "a"),
Some(sources.StringStartsWith("cstr", "a")))
+
+ testTranslateFilter(EndsWith(attrStr, "a"),
Some(sources.StringEndsWith("cstr", "a")))
+
+ testTranslateFilter(Contains(attrStr, "a"),
Some(sources.StringContains("cstr", "a")))
+ }
+
+ test("translate complex expression") {
+ val attrInt = 'cint.int
+
+ // ABS(cint) - 2 = 1
+ testTranslateFilter(LessThanOrEqual(
+ // Expressions are not supported
--- End diff --
?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
