Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19801#discussion_r152880052
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -660,40 +626,68 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
}
def unapply(values: Set[Any]): Option[Seq[String]] = {
- values.toSeq.foldLeft(Option(Seq.empty[String])) {
- case (Some(accum), value) if
valueToLiteralString.isDefinedAt(value) =>
- Some(accum :+ valueToLiteralString(value))
- case _ => None
+ val extractables = values.toSeq.map(valueToLiteralString.lift)
+ if (extractables.nonEmpty && extractables.forall(_.isDefined)) {
--- End diff --
The same here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
