Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19803#discussion_r152882876
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -56,9 +56,7 @@ case class ProjectExec(projectList: Seq[NamedExpression],
child: SparkPlan)
}
override def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row:
ExprCode): String = {
- val exprs = projectList.map(x =>
- ExpressionCanonicalizer.execute(BindReferences.bindReference(x,
child.output)))
- ctx.currentVars = input
+ val exprs = projectList.map(x =>
BindReferences.bindReference[Expression](x, child.output))
--- End diff --
This gets rid of `ExpressionCanonicalizer`. Isn't it possibly we have
`Alias` in `projectList` here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
