Github user ferdonline commented on a diff in the pull request:
https://github.com/apache/spark/pull/19805#discussion_r153145177
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -524,22 +524,41 @@ class Dataset[T] private[sql](
*/
@Experimental
@InterfaceStability.Evolving
- def checkpoint(): Dataset[T] = checkpoint(eager = true)
+ def checkpoint(eager: Boolean = true): Dataset[T] = _checkpoint(eager =
eager)
--- End diff --
I always try to avoid duplication of code, and with docs this takes ~10
lines for nothing - I believe a function with a default parameter is as
readable as the function without the parameter. But please let me know if it
goes against the code style. Thanks
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
