Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19828#discussion_r153242129
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -836,6 +836,16 @@ case class RepartitionByExpression(
         child: LogicalPlan,
         numPartitions: Int) extends RepartitionOperation {
     
    +  val (sortOrder, nonSortOrder) = 
partitionExpressions.partition(_.isInstanceOf[SortOrder])
    +
    +  require(sortOrder.isEmpty || nonSortOrder.isEmpty,
    +    s"""${getClass.getSimpleName} expects that either all its 
`partitionExpressions` are of type
    --- End diff --
    
    Do you want this to be a multiline message? it makes sense to put the sort 
order and non sort order on new lines.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to