Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19827#discussion_r153324495
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
 ---
    @@ -167,9 +160,20 @@ object GenerateUnsafeProjection extends 
CodeGenerator[Seq[Expression], UnsafePro
             }
         }
     
    +    val writeFieldsCode = if (isTopLevel && row == null) {
    +      // TODO: support whole stage codegen
    +      writeFields.mkString("\n")
    +    } else {
    +      assert(row != null)
    --- End diff --
    
    So far, it is safe, but the others might break it. Let us issue a 
reasonable error message?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to