Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19468#discussion_r153327654
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
 ---
    @@ -0,0 +1,70 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.scheduler.cluster.k8s
    +
    +import java.io.File
    +
    +import io.fabric8.kubernetes.client.Config
    +
    +import org.apache.spark.SparkContext
    +import org.apache.spark.deploy.k8s.Config._
    +import org.apache.spark.deploy.k8s.Constants._
    +import org.apache.spark.deploy.k8s.SparkKubernetesClientFactory
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.scheduler.{ExternalClusterManager, 
SchedulerBackend, TaskScheduler, TaskSchedulerImpl}
    +import org.apache.spark.util.ThreadUtils
    +
    +private[spark] class KubernetesClusterManager extends 
ExternalClusterManager with Logging {
    +
    +  override def canCreate(masterURL: String): Boolean = 
masterURL.startsWith("k8s")
    +
    +  override def createTaskScheduler(sc: SparkContext, masterURL: String): 
TaskScheduler = {
    +    new TaskSchedulerImpl(sc)
    +  }
    +
    +  override def createSchedulerBackend(
    +      sc: SparkContext,
    +      masterURL: String,
    +      scheduler: TaskScheduler): SchedulerBackend = {
    +    val sparkConf = sc.getConf
    +
    +    val kubernetesClient = 
SparkKubernetesClientFactory.createKubernetesClient(
    +      KUBERNETES_MASTER_INTERNAL_URL,
    +      Some(sparkConf.get(KUBERNETES_NAMESPACE)),
    +      APISERVER_AUTH_DRIVER_MOUNTED_CONF_PREFIX,
    +      sparkConf,
    +      Some(new File(Config.KUBERNETES_SERVICE_ACCOUNT_TOKEN_PATH)),
    +      Some(new File(Config.KUBERNETES_SERVICE_ACCOUNT_CA_CRT_PATH)))
    +
    +    val executorPodFactory = new ExecutorPodFactoryImpl(sparkConf)
    +    val allocatorExecutor = ThreadUtils
    +      .newDaemonSingleThreadScheduledExecutor("kubernetes-pod-allocator")
    +    val requestExecutorsService = ThreadUtils.newDaemonCachedThreadPool(
    +      "kubernetes-executor-requests")
    --- End diff --
    
    Sounds good.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to