Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19827#discussion_r153410825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -167,9 +160,20 @@ object GenerateUnsafeProjection extends
CodeGenerator[Seq[Expression], UnsafePro
}
}
+ val writeFieldsCode = if (isTopLevel && row == null) {
--- End diff --
`GenerateUnsafeProjection` is an compile unit by itself. The generated from
it doesn't mix with wholestage codegen. It also has its codegen context. That
is why I think this change doesn't make much sense. It also doesn't make sense
to support wholestage codegen for it, IIUC.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
