Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r153548730
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverServiceBootstrapStep.scala
 ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.submit.steps
    +
    +import scala.collection.JavaConverters._
    +
    +import io.fabric8.kubernetes.api.model.ServiceBuilder
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.deploy.k8s.Config._
    +import org.apache.spark.deploy.k8s.Constants._
    +import org.apache.spark.deploy.k8s.submit.KubernetesDriverSpec
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.util.Clock
    +
    +/**
    + * Allows the driver to be reachable by executor pods through a headless 
service. The service's
    + * ports should correspond to the ports that the executor will reach the 
pod at for RPC.
    + */
    +private[spark] class DriverServiceBootstrapStep(
    +    kubernetesResourceNamePrefix: String,
    +    driverLabels: Map[String, String],
    +    submissionSparkConf: SparkConf,
    +    clock: Clock) extends DriverConfigurationStep with Logging {
    +  import DriverServiceBootstrapStep._
    +
    +  override def configureDriver(driverSpec: KubernetesDriverSpec): 
KubernetesDriverSpec = {
    +    require(submissionSparkConf.getOption(DRIVER_BIND_ADDRESS_KEY).isEmpty,
    +      s"$DRIVER_BIND_ADDRESS_KEY is not supported in Kubernetes mode, as 
the driver's bind" +
    +      " address is managed and set to the driver pod's IP address.")
    +    require(submissionSparkConf.getOption(DRIVER_HOST_KEY).isEmpty,
    +      s"$DRIVER_HOST_KEY is not supported in Kubernetes mode, as the 
driver's hostname will be" +
    +      " managed via a Kubernetes service.")
    --- End diff --
    
    Done.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to