Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153709924
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends SparkFunSuite {
message.clientSparkVersion = "1.2.3"
message.appResource = "honey-walnut-cherry.jar"
message.mainClass = "org.apache.spark.examples.SparkPie"
+ message.appArgs = Array("hdfs://tmp/auth")
+ message.environmentVariables = Map("SPARK_HOME" -> "/test")
--- End diff --
@susanxhuynh Yes we have to make sure we don't break the Standalone mode.
I've reviewed StandaloneSubmitRequestServlet class and i think we might be
facing the same problem here, (L.126-131) You can find checks for 'appResource'
and 'mainClass' but not for 'appArgs'(L.140) or 'environmentVariables'(L.143)
when they could be null as they are initialised as null.
I think is the same case, let me know what you think.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
