Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19714#discussion_r153770711
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -149,10 +147,43 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
case _ => false
}
+ private def broadcastBuildSide(
+ canBuildLeft: Boolean,
+ canBuildRight: Boolean,
+ left: LogicalPlan,
+ right: LogicalPlan): BuildSide = {
+
+ // Both sides have broadcast hint, broadcast smaller side base on
its estimated physical size.
+ def buildSideBaseSize =
--- End diff --
nit: `smallerSide`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
