Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r153852136
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -109,6 +109,7 @@ private[sql] trait ColumnarBatchScan extends
CodegenSupport {
ctx.currentVars = null
val rowidx = ctx.freshName("rowIdx")
+ ctx.addMutableState(ctx.JAVA_INT, rowidx)
--- End diff --
Do we have to make this global? If so, it would be good to add a comment
since it is not easy to understand where `$rowidx` is used.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
