Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19848#discussion_r153957791
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
    @@ -106,6 +106,13 @@ abstract class FileCommitProtocol {
        */
       def commitTask(taskContext: TaskAttemptContext): TaskCommitMessage
     
    +  /**
    +   * Commits a task which blongs to a specific stage after the writes 
succeed.
    +   * Must be called on the executors when running tasks.
    +   */
    +  private[spark]
    +  def commitTask(taskContext: TaskAttemptContext, stageId: Int): 
TaskCommitMessage
    --- End diff --
    
    Modifiers should be in the same line as method declarations, all over your 
patch. Just look at existing code and follow the style.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to