Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19783#discussion_r153979438
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
 ---
    @@ -114,4 +114,197 @@ object EstimationUtils {
         }
       }
     
    +  /**
    +   * Returns the number of the first bin into which a column values falls 
for a specified
    +   * numeric equi-height histogram.
    +   *
    +   * @param value a literal value of a column
    +   * @param histogram a numeric equi-height histogram
    +   * @return the number of the first bin into which a column values falls.
    +   */
    +
    +  def findFirstBinForValue(value: Double, histogram: Histogram): Int = {
    +    var binId = 0
    +    histogram.bins.foreach { bin =>
    +      if (value > bin.hi) binId += 1
    +    }
    +    binId
    +  }
    +
    +  /**
    +   * Returns the number of the last bin into which a column values falls 
for a specified
    +   * numeric equi-height histogram.
    +   *
    +   * @param value a literal value of a column
    +   * @param histogram a numeric equi-height histogram
    +   * @return the number of the last bin into which a column values falls.
    +   */
    +
    +  def findLastBinForValue(value: Double, histogram: Histogram): Int = {
    +    var binId = 0
    +    for (i <- 0 until histogram.bins.length) {
    +      if (value > histogram.bins(i).hi) {
    +        // increment binId to point to next bin
    +        binId += 1
    +      }
    +      if ((value == histogram.bins(i).hi) && (i < histogram.bins.length - 
1)) {
    +        if (value == histogram.bins(i + 1).lo) {
    +          // increment binId since the value appears into this bin and 
next bin
    +          binId += 1
    +        }
    +      }
    +    }
    +    binId
    +  }
    +
    +  /**
    +   * Returns a percentage of a bin holding values for column value in the 
range of
    +   * [lowerValue, higherValue]
    +   *
    +   * @param binId a given bin id in a specified histogram
    +   * @param higherValue a given upper bound value of a specified column 
value range
    +   * @param lowerValue a given lower bound value of a specified column 
value range
    +   * @param histogram a numeric equi-height histogram
    +   * @return the percentage of a single bin holding values in [lowerValue, 
higherValue].
    +   */
    +
    +  private def getOccupation(
    +      binId: Int,
    +      higherValue: Double,
    +      lowerValue: Double,
    +      histogram: Histogram): Double = {
    +    val curBin = histogram.bins(binId)
    +    if (binId == 0 && curBin.hi == curBin.lo) {
    +      // the Min of the histogram occupies the whole first bin
    +      1.0
    +    } else if (binId == 0 && curBin.hi != curBin.lo) {
    +      if (higherValue == lowerValue) {
    +        // in the case curBin.binNdv == 0, current bin is occupied by one 
value, which
    --- End diff --
    
    binNdv will never be zero


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to