Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19783#discussion_r153976879
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
 ---
    @@ -529,6 +575,55 @@ case class FilterEstimation(plan: Filter) extends 
Logging {
         Some(percent)
       }
     
    +  /**
    +   * Returns the selectivity percentage for a combined op-dataNumber in 
the column's
    +   * current valid range [min, max]
    +   *
    +   * @param op a binary comparison operator
    +   * @param histogram a numeric equi-height histogram
    +   * @param max the upper bound of the current valid range for a given 
column
    +   * @param min the lower bound of the current valid range for a given 
column
    +   * @param datumNumber the numeric value of a literal
    +   * @return the selectivity percentage for a condition in the current 
range.
    +   */
    +
    +  def computePercentForNumericEquiHeightHgm(
    --- End diff --
    
    `computePercentByEquiHeightHgm` or just `computePercentByHistogram`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to