Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19847#discussion_r153979430
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -76,10 +77,8 @@ class VectorizedHashMapGenerator(
}.mkString("\n").concat(";")
s"""
- | private
org.apache.spark.sql.execution.vectorized.OnHeapColumnVector[] batchVectors;
- | private
org.apache.spark.sql.execution.vectorized.OnHeapColumnVector[] bufferVectors;
- | private org.apache.spark.sql.execution.vectorized.ColumnarBatch
batch;
--- End diff --
I don't have so strong feeling but can we keep `batch` here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
