Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19831#discussion_r154499581
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -1187,6 +1187,22 @@ class HiveQuerySuite extends HiveComparisonTest with
SQLTestUtils with BeforeAnd
}
}
}
+
+ test("Wrong Hive table statistics may trigger OOM if enables join
reorder in CBO") {
--- End diff --
IMHO you can just test the read logic for Hive's stats properties in
`StatisticsSuite`, instead of a end-to-end test case, developers may not know
what's going on by this test case.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]