Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18995#discussion_r154537895
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala
---
@@ -15,20 +15,21 @@
* limitations under the License.
*/
-package org.apache.spark.sql.hive.orc
+package org.apache.spark.sql.execution.datasources.orc
import java.io.File
import scala.reflect.ClassTag
import scala.reflect.runtime.universe.TypeTag
import org.apache.spark.sql._
-import org.apache.spark.sql.hive.test.TestHiveSingleton
import org.apache.spark.sql.test.SQLTestUtils
-private[sql] trait OrcTest extends SQLTestUtils with TestHiveSingleton {
+abstract class OrcTest extends QueryTest with SQLTestUtils {
import testImplicits._
+ protected def format: String
--- End diff --
By using full canonical class names, we will explicitly test new
OrcFileFormat in `sql/core` and old OrcFileFormat in `sql/hive` without
considering SQL ORC switching conf.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
