Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r154549172
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -296,6 +298,12 @@ object SparkSubmit extends CommandLineUtils with 
Logging {
           case (STANDALONE, CLUSTER) if args.isR =>
             printErrorAndExit("Cluster deploy mode is currently not supported 
for R " +
               "applications on standalone clusters.")
    +      case (KUBERNETES, CLIENT) =>
    +        printErrorAndExit("Client mode is currently not supported for 
Kubernetes.")
    +      case (KUBERNETES, _) if args.isPython =>
    +        printErrorAndExit("Python applications are currently not supported 
for Kubernetes.")
    +      case (KUBERNETES, _) if args.isR =>
    +        printErrorAndExit("R applications are currently not supported for 
Kubernetes.")
    --- End diff --
    
    nit: Not affect the result, but logically I think it is better:
    
    ```scala
    case (KUBERNETES, _) if args.isPython =>
      printErrorAndExit("Python applications are currently not supported for 
Kubernetes.")
    case (KUBERNETES, _) if args.isR =>
      printErrorAndExit("R applications are currently not supported for 
Kubernetes.")
    case (KUBERNETES, CLIENT) =>
      printErrorAndExit("Client mode is currently not supported for 
Kubernetes.")
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to