Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19869#discussion_r154565659
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -768,12 +762,8 @@ case class HashAggregateExec(
// generate hash code for key
val hashExpr = Murmur3Hash(groupingExpressions, 42)
- ctx.currentVars = input
val hashEval = BindReferences.bindReference(hashExpr,
child.output).genCode(ctx)
- val inputAttr = aggregateBufferAttributes ++ child.output
- ctx.currentVars = new
Array[ExprCode](aggregateBufferAttributes.length) ++ input
-
val (checkFallbackForGeneratedHashMap,
checkFallbackForBytesToBytesMap, resetCounter,
incCounter) = if (testFallbackStartsAt.isDefined) {
--- End diff --
nit: need some indents in the head?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
