Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154575588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -108,7 +108,10 @@ private[sql] trait ColumnarBatchScan extends
CodegenSupport {
|}""".stripMargin)
ctx.currentVars = null
+ // `rowIdx` isn't in `ctx.currentVars`. If the expressions are split
later, we can't track it.
+ // So making it as global variable.
--- End diff --
can we add `rowId` to `ExprCode.inputVars` in `genCodeColumnVector`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
