Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154640805
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,12 @@ object DataSource extends Logging {
"org.apache.spark.Logging")
/** Given a provider name, look up the data source class definition. */
- def lookupDataSource(provider: String): Class[_] = {
- val provider1 = backwardCompatibilityMap.getOrElse(provider, provider)
+ def lookupDataSource(conf: SQLConf, provider: String): Class[_] = {
--- End diff --
After more thinking, I think it don't worth to pass the whole SQLConf into
this function, we just need to know whether `SQLConf.ORC_USE_NEW_VERSION` is
enabled.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
