Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154721032
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.submit
+
+import java.util.concurrent.{CountDownLatch, TimeUnit}
+
+import scala.collection.JavaConverters._
+
+import io.fabric8.kubernetes.api.model.{ContainerStateRunning,
ContainerStateTerminated, ContainerStateWaiting, ContainerStatus, Pod, Time}
+import io.fabric8.kubernetes.client.{KubernetesClientException, Watcher}
+import io.fabric8.kubernetes.client.Watcher.Action
+
+import org.apache.spark.SparkException
+import org.apache.spark.internal.Logging
+import org.apache.spark.util.ThreadUtils
+
+private[k8s] trait LoggingPodStatusWatcher extends Watcher[Pod] {
+ def awaitCompletion(): Unit
+}
+
+/**
+ * A monitor for the running Kubernetes pod of a Spark application. Status
logging occurs on
+ * every state change and also at an interval for liveness.
+ *
+ * @param appId application ID.
+ * @param maybeLoggingInterval ms between each state request. If provided,
must be a positive
+ * number.
+ */
+private[k8s] class LoggingPodStatusWatcherImpl(
+ appId: String,
+ maybeLoggingInterval: Option[Long])
+ extends LoggingPodStatusWatcher with Logging {
+
+ private val podCompletedFuture = new CountDownLatch(1)
+ // start timer for periodic logging
+ private val scheduler =
+
ThreadUtils.newDaemonSingleThreadScheduledExecutor("logging-pod-status-watcher")
+ private val logRunnable: Runnable = new Runnable {
+ override def run() = logShortStatus()
+ }
+
+ private var pod = Option.empty[Pod]
+
+ private def phase: String =
pod.map(_.getStatus.getPhase).getOrElse("unknown")
+
+ def start(): Unit = {
+ maybeLoggingInterval.foreach { interval =>
+ require(interval > 0, s"Logging interval must be a positive time
value, got: $interval ms.")
+ scheduler.scheduleAtFixedRate(logRunnable, 0, interval,
TimeUnit.MILLISECONDS)
+ }
+ }
+
+ override def eventReceived(action: Action, pod: Pod): Unit = {
+ this.pod = Option(pod)
+ action match {
+ case Action.DELETED | Action.ERROR =>
+ closeWatch()
+
+ case _ =>
+ logLongStatus()
+ if (hasCompleted()) {
+ closeWatch()
+ }
+ }
+ }
+
+ override def onClose(e: KubernetesClientException): Unit = {
+ logDebug(s"Stopping watching application $appId with last-observed
phase $phase")
+ closeWatch()
+ }
+
+ private def logShortStatus() = {
+ logInfo(s"Application status for $appId (phase: $phase)")
+ }
+
+ private def logLongStatus() = {
+ logInfo("State changed, new state: " +
pod.map(formatPodState).getOrElse("unknown"))
+ }
+
+ private def hasCompleted(): Boolean = {
+ phase == "Succeeded" || phase == "Failed"
+ }
+
+ private def closeWatch(): Unit = {
+ podCompletedFuture.countDown()
+ scheduler.shutdown()
+ }
+
+ private def formatPodState(pod: Pod): String = {
+ // TODO include specific container state
--- End diff --
Actually it already includes the `containerStatuses`. Removed this TODO.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
