Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154755799
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -537,6 +540,7 @@ object DataSource extends Logging {
val csv = classOf[CSVFileFormat].getCanonicalName
val libsvm = "org.apache.spark.ml.source.libsvm.LibSVMFileFormat"
val orc = "org.apache.spark.sql.hive.orc.OrcFileFormat"
+ val newOrc = classOf[OrcFileFormat].getCanonicalName
--- End diff --
Please do not use the name like `newXYZ`. When the newer one was added, the
name will be confusing.
How about `nativeOrc`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
