Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r154757417
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
 ---
    @@ -0,0 +1,181 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.submit
    +
    +import java.util.concurrent.{CountDownLatch, TimeUnit}
    +
    +import scala.collection.JavaConverters._
    +
    +import io.fabric8.kubernetes.api.model.{ContainerStateRunning, 
ContainerStateTerminated, ContainerStateWaiting, ContainerStatus, Pod, Time}
    +import io.fabric8.kubernetes.client.{KubernetesClientException, Watcher}
    +import io.fabric8.kubernetes.client.Watcher.Action
    +
    +import org.apache.spark.SparkException
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.util.ThreadUtils
    +
    +private[k8s] trait LoggingPodStatusWatcher extends Watcher[Pod] {
    +  def awaitCompletion(): Unit
    +}
    +
    +/**
    + * A monitor for the running Kubernetes pod of a Spark application. Status 
logging occurs on
    + * every state change and also at an interval for liveness.
    + *
    + * @param appId application ID.
    + * @param maybeLoggingInterval ms between each state request. If provided, 
must be a positive
    + *                             number.
    + */
    +private[k8s] class LoggingPodStatusWatcherImpl(
    +    appId: String,
    +    maybeLoggingInterval: Option[Long])
    +  extends LoggingPodStatusWatcher with Logging {
    +
    +  private val podCompletedFuture = new CountDownLatch(1)
    +  // start timer for periodic logging
    +  private val scheduler =
    +    
ThreadUtils.newDaemonSingleThreadScheduledExecutor("logging-pod-status-watcher")
    +  private val logRunnable: Runnable = new Runnable {
    +    override def run() = logShortStatus()
    +  }
    +
    +  private var pod = Option.empty[Pod]
    +
    +  private def phase: String = 
pod.map(_.getStatus.getPhase).getOrElse("unknown")
    +
    +  def start(): Unit = {
    +    maybeLoggingInterval.foreach { interval =>
    +      require(interval > 0, s"Logging interval must be a positive time 
value, got: $interval ms.")
    --- End diff --
    
    You could use `.checkValue` in the constant declaration instead.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to