Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154884137
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -621,4 +621,21 @@ class OrcQuerySuite extends QueryTest with
BeforeAndAfterAll with OrcTest {
makeOrcFile((1 to 10).map(Tuple1.apply), path2)
assertResult(20)(read.orc(path1.getCanonicalPath,
path2.getCanonicalPath).count())
}
+
+ test("SPARK-20728 Make ORCFileFormat configurable between sql/hive and
sql/core") {
+ Seq(
+ ("native",
classOf[org.apache.spark.sql.execution.datasources.orc.OrcFileFormat]),
+ ("hive",
classOf[org.apache.spark.sql.hive.orc.OrcFileFormat])).foreach { case (i,
format) =>
--- End diff --
nit: `i` => `orcImpl`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
