Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19891#discussion_r154965863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -548,8 +548,8 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
castCode(ctx, eval.value, eval.isNull, ev.value, ev.isNull,
dataType, nullSafeCast))
}
- // three function arguments are: child.primitive, result.primitive and
result.isNull
- // it returns the code snippets to be put in null safe evaluation region
+ // The function arguments are: `input`, `result` and `resultIsNull`. We
don't need `inputIsNull`
+ // in parameter list, because the returned code will be put in null safe
evaluation region.
--- End diff --
some renaming to make it more readable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
