GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/19899

    [SPARK-22704][SQL] Least and Greatest use less global variables

    ## What changes were proposed in this pull request?
    
    This PR accomplishes the following two items.
    
    1. Reduce # of global variables from two to one
    2. Make lifetime of global variable local within an operation
    
    1. reduces # of constant pool entries in a Java class. 2. ensures that an 
variable is not passed to arguments in a method split by 
`CodegenContext.splitExpressions()`, which is addressed by #19865.
    
    ## How was this patch tested?
    
    Added new test into `ArithmeticExpressionSuite`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-22704

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19899.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19899
    
----
commit 544d23d599fa89b58f7eb394dd034515fd1eba1a
Author: Kazuaki Ishizaki <[email protected]>
Date:   2017-12-05T15:47:16Z

    initial commit

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to