GitHub user kiszk opened a pull request:

    https://github.com/apache/spark/pull/19901

    [SPARK-22705][SQL] Case, Coalesce, and In use less global variables

    ## What changes were proposed in this pull request?
    
    This PR accomplishes the following two items.
    
    1. Reduce # of global variables from two to one for generated code of 
`Case` and `Coalesce` and remove global variables for generated code of `In`.
    2. Make lifetime of global variable local within an operation
      
    Item 1. reduces # of constant pool entries in a Java class. Item 2. ensures 
that an variable is not passed to arguments in a method split by 
`CodegenContext.splitExpressions()`, which is addressed by #19865.
    
    ## How was this patch tested?
    
    Added new tests into `PredicateSuite`, `NullExpressionsSuite`, and 
`ConditionalExpressionSuite`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiszk/spark SPARK-22705

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19901.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19901
    
----

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to