Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19901#discussion_r155132859
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -237,53 +237,58 @@ case class In(value: Expression, list: 
Seq[Expression]) extends Predicate {
         val javaDataType = ctx.javaType(value.dataType)
         val valueGen = value.genCode(ctx)
         val listGen = list.map(_.genCode(ctx))
    -    ctx.addMutableState(ctx.JAVA_BOOLEAN, ev.value)
    -    ctx.addMutableState(ctx.JAVA_BOOLEAN, ev.isNull)
    +    // inValue  -1:isNull, 0:false, 1:true
    +    val inValue = ctx.freshName("value")
    --- End diff --
    
    nit: `inTmpResult`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to