Github user henryr commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r155359296
--- Diff: core/src/test/resources/thread_whitelist ---
@@ -0,0 +1,24 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Each line contains a new regex string which will be evaluated with
matches
+# Empty lines or starting with # will me skipped
+
+rpc-client.*
--- End diff --
Agree with Sean here - there's not a really obvious use case for having
this independent of the class where it's used. Putting it into the code means
that the whitelist feature is self-documenting, and you don't have to go
through any indirection to find this file.
Plus I think moving this into SparkFunSuite means you can get rid of the
file loading logic in 'object SparkFunSuite'.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
