Github user rednaxelafx commented on the issue:

    https://github.com/apache/spark/pull/19890
  
    I'd LGTM on both upgrading to Janino 3.0.8 and also changing the exception 
type captured from `JaninoRuntimeException` to the new 
`InternalCompilerException`. It's never a good idea to have conflicting library 
version on the classpath anyway, hitting an error in terms of 
`ClassNotFoundException` or `NoClassDefFoundError` on this new exception type 
is actually a good hint that there is a version conflict -- it'd be nice if we 
can document this knowledge somewhere easy to find, though.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to