Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155605695 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { // scalastyle:on + val threadWhiteList = Set( + /** + * Netty related threads. + */ + "netty.*", + + /** + * A Single-thread singleton EventExecutor inside netty which creates such threads. + */ + "globalEventExecutor.*", + + /** + * Netty creates such threads. + * Checks if a thread is alive periodically and runs a task when a thread dies. + */ + "threadDeathWatcher.*", + + /** + * These threads are created by spark when internal RPC environment initialized and later used. --- End diff -- Fully agree with your stand and tests should stop their context. What I see is that majority of tests are just not doing that. OK, then I suggest to remove them from the whitelist. Agreed?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org