Github user smurakozi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19920#discussion_r155611738
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -24,27 +24,32 @@ import
com.fasterxml.jackson.databind.annotation.JsonDeserialize
import org.apache.spark.JobExecutionStatus
-class ApplicationInfo private[spark](
- val id: String,
- val name: String,
- val coresGranted: Option[Int],
- val maxCores: Option[Int],
- val coresPerExecutor: Option[Int],
- val memoryPerExecutorMB: Option[Int],
- val attempts: Seq[ApplicationAttemptInfo])
+case class ApplicationInfo private[spark](
--- End diff --
We check equality of ApplicationInfos during testing. I think converting
them to case classes introduce less complexity than adding a proper equals
method (ditto for ApplicationAttemptInfo below).
In addition we copy ApplicationInfos in FsHistoryProvider:819, it's also
simpler with case classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
