Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r155900585
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
 ---
    @@ -119,5 +117,46 @@ private[spark] object Config extends Logging {
             "must be a positive integer")
           .createWithDefault(10)
     
    +  val WAIT_FOR_APP_COMPLETION =
    +    ConfigBuilder("spark.kubernetes.submission.waitAppCompletion")
    +      .doc("In cluster mode, whether to wait for the application to finish 
before exiting the " +
    +        "launcher process.")
    +      .booleanConf
    +      .createWithDefault(true)
    +
    +  val REPORT_INTERVAL =
    +    ConfigBuilder("spark.kubernetes.report.interval")
    +      .doc("Interval between reports of the current app status in cluster 
mode.")
    +      .timeConf(TimeUnit.MILLISECONDS)
    +      .checkValue(interval => interval > 0, s"Logging interval must be a 
positive time value.")
    +      .createWithDefaultString("1s")
    +
    +  private[spark] val JARS_DOWNLOAD_LOCATION =
    --- End diff --
    
    nit: `private[spark]` is redundant in this object.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to