Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r155926316
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
s"""
|while (findNextInnerJoinRows($leftInput, $rightInput)) {
+ | ${leftVarDecl.mkString("\n")}
--- End diff --
It could be. Would it be possible to let us know advantages compare to the
current method?
I think that to shorten lifetime of variables (i.e. current approach) make
generated code more readable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
