Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19872#discussion_r156037157
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
 ---
    @@ -48,9 +48,26 @@ object ExtractPythonUDFFromAggregate extends 
Rule[LogicalPlan] {
         }.isDefined
       }
     
    +  private def isPandasGroupAggUdf(expr: Expression): Boolean = expr match {
    +      case _ @ PythonUDF(_, _, _, _, 
PythonEvalType.SQL_PANDAS_GROUP_AGG_UDF ) => true
    --- End diff --
    
    We don't need `_ @` here.
    nit: remove extra space after `SQL_PANDAS_GROUP_AGG_UDF`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to