Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19916#discussion_r156112761
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -309,8 +309,9 @@ case class Literal (value: Any, dataType: DataType)
extends LeafExpression {
ev.copy(code = "", value = s"($javaType)$value")
case TimestampType | LongType =>
ev.copy(code = "", value = s"${value}L")
- case other =>
- ev.copy(code = "", value = ctx.addReferenceMinorObj(value,
ctx.javaType(dataType)))
+ case _ =>
+ ev.copy(code = "", value = ctx.addReferenceObj("literalValue",
value,
--- End diff --
nit: `literal` instead of `literalValue`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
