Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19942#discussion_r156177369
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -291,6 +291,18 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
if (proxyUser != null && principal != null) {
SparkSubmit.printErrorAndExit("Only one of --proxy-user or
--principal can be provided.")
}
+
+ val executorTimeoutThreshold = Utils.timeStringAsSeconds(
+ sparkProperties.getOrElse("spark.network.timeout", "120s"))
+ val executorHeartbeatInterval = Utils.timeStringAsSeconds(
+ sparkProperties.getOrElse("spark.executor.heartbeatInterval", "10s"))
--- End diff --
The best place is probably `SparkConf.validateSettings`. I don't see a way
to not duplicate the defaults, though - they're already duplicated in a bunch
of places. The right way would be to create a config constant, but that would
be a much noisier change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
